Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumb down FRI #529

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Dumb down FRI #529

merged 1 commit into from
Apr 3, 2024

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Mar 22, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

This was referenced Mar 22, 2024
Merged
Merged
Merged
Merged
@spapinistarkware Graphite App
Copy link
Contributor Author

spapinistarkware commented Mar 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite Graphite

This was referenced Mar 22, 2024
Merged
Merged
Merged
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.25287% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 94.18%. Comparing base (ea89ad5) to head (b0d6532).

Files Patch % Lines
src/core/poly/circle/secure_poly.rs 0.00% 6 Missing ⚠️
src/core/fields/secure_column.rs 90.00% 3 Missing ⚠️
src/core/poly/line.rs 97.36% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #529      +/-   ##
==========================================
- Coverage   94.33%   94.18%   -0.16%     
==========================================
  Files          68       68              
  Lines       10290    10229      -61     
  Branches    10290    10229      -61     
==========================================
- Hits         9707     9634      -73     
- Misses        513      525      +12     
  Partials       70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 4e92a87 to 15f1943 Compare March 24, 2024 13:48
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from f28ec8a to 9fd7e97 Compare March 24, 2024 13:48
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 15f1943 to 8be977f Compare March 24, 2024 14:24
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from 9fd7e97 to b9fbca3 Compare March 24, 2024 14:25
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 8be977f to 5018f1d Compare March 24, 2024 14:30
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from b9fbca3 to f6dc248 Compare March 24, 2024 14:30
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 5018f1d to 78b3282 Compare March 24, 2024 15:07
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from f6dc248 to 0013465 Compare March 24, 2024 15:07
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 78b3282 to fe2a9d6 Compare March 25, 2024 05:20
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch 2 times, most recently from 14c3f19 to f2b1290 Compare March 25, 2024 06:00
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from fe2a9d6 to 9a69392 Compare March 25, 2024 06:05
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from f2b1290 to 683b31e Compare March 25, 2024 06:09
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 9a69392 to 89b58a1 Compare March 25, 2024 06:14
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch 2 times, most recently from 1f0091d to bcfc8b3 Compare March 25, 2024 06:28
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 89b58a1 to 4e95a34 Compare March 25, 2024 09:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from bcfc8b3 to 9d3f2ab Compare March 25, 2024 09:22
andrewmilson
andrewmilson approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 10 files at r1, 3 of 7 files at r2, all commit messages.
Reviewable status: 4 of 13 files reviewed, all discussions resolved

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 4e95a34 to 494fd27 Compare March 25, 2024 12:00
This was referenced Mar 27, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
andrewmilson
andrewmilson requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r5, all commit messages.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

src/core/commitment_scheme/verifier.rs line 103 at r5 (raw file):

                tree.verify(queries, queried_values, decommitment)
            })
            .0

What is this value?

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 467dd27 to 4dcef9e Compare March 28, 2024 09:43
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from 2c85fba to 11cec6b Compare March 28, 2024 09:43
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 4dcef9e to e335956 Compare April 2, 2024 11:26
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from 11cec6b to 81c05a6 Compare April 2, 2024 11:26
spapinistarkware
spapinistarkware commented Apr 2, 2024
View reviewed changes
Copy link
Contributor Author

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 14 files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

src/core/commitment_scheme/verifier.rs line 103 at r5 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

What is this value?

It's a TreeVec. .0 accesses the inner Vec.

andrewmilson
andrewmilson approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r5, 5 of 5 files at r7.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from e335956 to ec4c606 Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from 81c05a6 to b692b13 Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from ec4c606 to 332c978 Compare April 3, 2024 06:34
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from b692b13 to 4559157 Compare April 3, 2024 06:45
andrewmilson
andrewmilson approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-avx_merkle branch from 332c978 to 2282529 Compare April 3, 2024 10:53
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from 4559157 to dcfe7e9 Compare April 3, 2024 10:55
@shaharsamocha7 shaharsamocha7 changed the base branch from spapini/03-22-avx_merkle to dev April 3, 2024 11:15
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-dumb_down_fri branch from dcfe7e9 to b0d6532 Compare April 3, 2024 11:15
@spapinistarkware Graphite App
Copy link
Contributor Author

spapinistarkware commented Apr 3, 2024 •
edited
Loading

Merge activity

@spapinistarkware spapinistarkware merged commit c3327b8 into dev Apr 3, 2024
12 checks passed
@spapinistarkware spapinistarkware mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmilson andrewmilson andrewmilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spapinistarkware @codecov-commenter @andrewmilson