simple merkle benchmark

[spapinistarkware]

This change is 

[spapinistarkware]

• Remove old merkle #531 : 2 dependent PRs (#486 , #488 )
• FRI using simple merkle #530
• Dumb down FRI #529
• avx merkle #528
• simple merkle benchmark #527 👈
• Use simple merkle tree #526
• merkle intermediate layers #548
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (41a66ec) to head (f76f6e5).

Additional details and impacted files

@@                          Coverage Diff                           @@
##           spapini/03-22-use_simple_merkle_tree     #527    +/-   ##
======================================================================
  Coverage                                 95.19%   95.19%            
======================================================================
  Files                                        66       66            
  Lines                                     10327    10062   -265     
  Branches                                  10327    10062   -265     
======================================================================
- Hits                                       9831     9579   -252     
+ Misses                                      427      416    -11     
+ Partials                                     69       67     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 1 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

Cargo.toml line 16 at r2 (raw file):

merging-iterator = "1.3.0"
bytemuck = { version = "1.14.3", features = ["derive"] }
blake2 = "0.10.6"

Suggestion:

[dependencies]
blake2 = "0.10.6"
blake3 = "1.5.0"
hex = "0.4.3"
itertools = "0.12.0"
num-traits = "0.2.17"
thiserror = "1.0.56"
merging-iterator = "1.3.0"
bytemuck = { version = "1.14.3", features = ["derive"] }

---

Cargo.toml line 60 at r2 (raw file):

[[bench]]
name = "merkle"

What is the difference?
Rename or put them together

Code quote:

[[bench]]
name = "merkle_bench"
harness = false

[[bench]]
name = "merkle"

---

benches/merkle_bench.rs line 97 at r2 (raw file):

        )
    });
}

Why did you remove this?
Do we need any benches from this file?

Code quote:

fn single_blake2s_hash_benchmark(c: &mut Criterion) {
    let input = [0u8; 1];
    c.bench_function("Single blake2s hash", |b| {
        b.iter_batched(
            || -> Blake2s256 { Blake2s256::new() },
            |mut h| {
                h.update(&input[..]);
                h.finalize()
            },
            BatchSize::SmallInput,
        )
    });
}

[spapinistarkware]

Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

Cargo.toml line 16 at r2 (raw file):

merging-iterator = "1.3.0"
bytemuck = { version = "1.14.3", features = ["derive"] }
blake2 = "0.10.6"

Done.

---

Cargo.toml line 60 at r2 (raw file):

Previously, shaharsamocha7 wrote…

What is the difference?
Rename or put them together

merkle_bench will be removed soon

---

benches/merkle_bench.rs line 97 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Why did you remove this?
Do we need any benches from this file?

Done.

[shaharsamocha7]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

---

benches/merkle_bench.rs line 2 at r3 (raw file):

use blake2::{Blake2s256, Digest};
// TODO(Ohad): write better benchmarks. Reduce the variance in sample size.

Revert change

Suggestion:

// TODO(Ohad): write better benchmarks. Reduce the variance in sample size.
use blake2::{Blake2s256, Digest};

[spapinistarkware]

Merge activity

• Apr 3, 2:30 AM EDT: Graphite rebased this pull request as part of a merge.
• Apr 3, 2:33 AM EDT: @spapinistarkware merged this pull request with Graphite.