Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterable trace #942

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

iterable trace #942

wants to merge 1 commit into from

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Dec 23, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 69.60784% with 31 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (f24cde6) to head (87c1b94).

Files with missing lines Patch % Lines
crates/air_utils/src/trace/iterable_trace.rs 69.60% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #942      +/-   ##
==========================================
- Coverage   92.52%   92.35%   -0.18%     
==========================================
  Files          97       98       +1     
  Lines       13319    13421     +102     
  Branches    13319    13421     +102     
==========================================
+ Hits        12324    12395      +71     
- Misses        925      956      +31     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-starkware ohad-starkware mentioned this pull request Dec 23, 2024
@ohad-starkware ohad-starkware self-assigned this Dec 23, 2024
This was referenced Dec 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: a58b4ca Previous: 87c1b94 Ratio
iffts/simd ifft/27 601218940 ns/iter (± 7342406) 294742651 ns/iter (± 11105005) 2.04
iffts/simd ifft/28 1259186484 ns/iter (± 27502525) 596468053 ns/iter (± 14464123) 2.11
merkle throughput/simd merkle 30455866 ns/iter (± 393327) 14840045 ns/iter (± 505562) 2.05

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants