Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example lookup data #944

Open
wants to merge 1 commit into
base: ohad/par_trace_iter
Choose a base branch
from

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ohad-starkware ohad-starkware mentioned this pull request Dec 23, 2024
Copy link
Collaborator Author

ohad-starkware commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ohad-starkware ohad-starkware mentioned this pull request Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 73.79310% with 38 lines in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (bdcdf24) to head (e681b1c).

Files with missing lines Patch % Lines
crates/air_utils/src/trace/examle_lookup_data.rs 73.79% 38 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           ohad/par_trace_iter     #944      +/-   ##
=======================================================
- Coverage                92.28%   92.08%   -0.20%     
=======================================================
  Files                       98       99       +1     
  Lines                    13513    13658     +145     
  Branches                 13513    13658     +145     
=======================================================
+ Hits                     12470    12577     +107     
- Misses                     973     1011      +38     
  Partials                    70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e681b1c Previous: 278d03e Ratio
iffts/simd ifft/28 1236124701 ns/iter (± 45493079) 592026725 ns/iter (± 11152081) 2.09

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants