Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

par trace #943

Open
wants to merge 1 commit into
base: ohad/trace_iter
Choose a base branch
from
Open

par trace #943

wants to merge 1 commit into from

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 74.73684% with 24 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (87c1b94) to head (a416c87).

Files with missing lines Patch % Lines
crates/air_utils/src/trace/iterable_trace.rs 74.73% 24 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           ohad/trace_iter     #943      +/-   ##
===================================================
- Coverage            92.35%   92.26%   -0.10%     
===================================================
  Files                   98       98              
  Lines                13421    13516      +95     
  Branches             13421    13516      +95     
===================================================
+ Hits                 12395    12470      +75     
- Misses                 956      976      +20     
  Partials                70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bdcdf24 Previous: a416c87 Ratio
iffts/simd ifft/21 6269610 ns/iter (± 170748) 3060088 ns/iter (± 80937) 2.05
iffts/simd ifft/22 12963254 ns/iter (± 234995) 6094724 ns/iter (± 136081) 2.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants