Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move two-layer shallow water equations from Trixi.jl #28

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

patrickersing
Copy link
Contributor

This PR adds the 1D and 2D version of the ShallowWaterEquationsTwoLayer, that were removed from Trixi.jl in trixi-framework/Trixi.jl#1809

@patrickersing patrickersing added the enhancement New feature or request label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.52%. Comparing base (4a508f2) to head (8c2b0b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   99.25%   99.52%   +0.26%     
==========================================
  Files          33       40       +7     
  Lines         942     1459     +517     
==========================================
+ Hits          935     1452     +517     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickersing patrickersing marked this pull request as ready for review March 11, 2024 09:15
@patrickersing
Copy link
Contributor Author

This is basically a direct copy from the files in Trixi.jl and I only had to qualify some of the functions.
I slightly restructured the testsets, which causes most of the deleted lines in this PR.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions, but overall this already looks good! It is nice how simple it was to load in a new set of equations.

src/equations/equations.jl Show resolved Hide resolved
src/equations/shallow_water_two_layer_1d.jl Show resolved Hide resolved
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 merged commit 4644c7e into trixi-framework:main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants