-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move two-layer shallow water equations from Trixi.jl #28
Move two-layer shallow water equations from Trixi.jl #28
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 99.25% 99.52% +0.26%
==========================================
Files 33 40 +7
Lines 942 1459 +517
==========================================
+ Hits 935 1452 +517
Misses 7 7 ☔ View full report in Codecov by Sentry. |
This is basically a direct copy from the files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions, but overall this already looks good! It is nice how simple it was to load in a new set of equations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the 1D and 2D version of the
ShallowWaterEquationsTwoLayer
, that were removed fromTrixi.jl
in trixi-framework/Trixi.jl#1809