forked from modm-io/modm
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ARUW's version of modm
to the latest
#4
Merged
MatthewMArnold
merged 136 commits into
uw-advanced-robotics:develop
from
modm-io:develop
Sep 24, 2020
Merged
Update ARUW's version of modm
to the latest
#4
MatthewMArnold
merged 136 commits into
uw-advanced-robotics:develop
from
modm-io:develop
Sep 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly prevent inclusion of module `:io` only for formatting functions!
As I understood the spec (and as Wikipedia states), “in the Remote Frame there is no Data Field. The DLC field indicates the data length of the requested message (not the transmitted one)”.
I was not able to receive messages from a CAN2USB. The mutex was already added but newer used.
It turned out that running from debugger the stack pointer might be wrong (initialized to the value of the system flash).
SCons also adds the directory of every SConscript to the Python path, so there is no need to explicitly add it again.
Co-authored-by: Niklas Hauser <[email protected]>
Co-authored-by: Niklas Hauser <[email protected]>
Co-authored-by: Niklas Hauser <[email protected]>
Fixes STM32L1 define/header selection
It was accidentally removed in 4332c14 when excluding files from “portable”.
Co-authored-by: delphi <[email protected]>
Looks good to me, feel free to go ahead. Two notes on that:
Obviously, make sure you test it at some point 😄 |
Also please tell me about any more Windows issues, we've recently added a Windows CI, and I was able to fix most of the issues from modm-io#310, but not all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ARUW's develop to the latest version of modm.