Fix SD-JWT examples; add detail to the 'Securing Verifiable Credentials' section #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Sep 18, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
requested changes
Sep 24, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
approved these changes
Sep 24, 2024
* origin/main: mark sections normative; move algorithms (#302) # Conflicts: # index.html
selfissued
reviewed
Sep 26, 2024
Co-authored-by: Michael B. Jones <[email protected]>
selfissued
reviewed
Sep 26, 2024
Co-authored-by: Michael B. Jones <[email protected]>
selfissued
reviewed
Sep 26, 2024
selfissued
reviewed
Sep 26, 2024
selfissued
reviewed
Sep 26, 2024
Co-authored-by: Michael B. Jones <[email protected]>
selfissued
approved these changes
Sep 27, 2024
|
Editorial approval. Open for over a week. Changes accepted. Merging. |
TallTed
reviewed
Sep 27, 2024
Comment on lines
+317
to
+318
| The JWT Claim Names <code>vc</code> and <code>vp</code> | ||
| MUST NOT be present in any JWT Claim Set. |
There was a problem hiding this comment.
Is this accurate? We're restricting use of JWT Claim Names vc and vp in any JWT Claim Set, even a JWT Claim Set that does not encode a Verifiable Credential or Verifiable Presentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #296
The next part is to update the respec-vc plugin to generate SD-JWT examples without KB-JWTs with a trailing
~(w3c/respec-vc#48).Preview | Diff