-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social | Standardize connections API schema #40536
Social | Standardize connections API schema #40536
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@@ -158,8 +159,7 @@ public static function get_store_initial_state() { | |||
|
|||
return array( | |||
'connectionData' => array( | |||
// We do not have this method on WPCOM Publicize class yet. | |||
'connections' => ! $is_wpcom ? self::publicize()->get_all_connections_for_user() : array(), | |||
'connections' => Connections::get_all( array( 'clear_cache' => true ) ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clear_cache
needs to be removed before merging.
4f35a37
to
f937e85
Compare
1986930
to
0b9b89f
Compare
f937e85
to
b6189d1
Compare
0b9b89f
to
4eb8da1
Compare
This reverts commit 3d17f8b.
533a92c
to
19726a5
Compare
Closing in favour of #40589 which uses a different approach |
Fixes #
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: