Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Standardize connections API schema #40536

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Dec 10, 2024

Fixes #

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply D168243-code to your sandbox and point public API and your site to it.
  • Goto connections management on a Jetpack site and verify that everything works same as before like adding, removing and updating connections.
  • On a Simple site, goto editor
  • Open Jetpack sidebar
  • Verify that Connections management now opens the modal, instead of pointing to Calypso
  • In the modal, confirm that the connections show up fine.
  • Note that adding/removing connections is not yet implemented for simple sites

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/unify-social-connections-schema branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/unify-social-connections-schema
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@manzoorwanijk manzoorwanijk added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Dec 10, 2024
@@ -158,8 +159,7 @@ public static function get_store_initial_state() {

return array(
'connectionData' => array(
// We do not have this method on WPCOM Publicize class yet.
'connections' => ! $is_wpcom ? self::publicize()->get_all_connections_for_user() : array(),
'connections' => Connections::get_all( array( 'clear_cache' => true ) ),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clear_cache needs to be removed before merging.

@manzoorwanijk manzoorwanijk requested a review from a team December 10, 2024 13:02
@manzoorwanijk manzoorwanijk force-pushed the update/unify-social-connections-schema branch from 4f35a37 to f937e85 Compare December 11, 2024 12:45
@manzoorwanijk manzoorwanijk changed the base branch from trunk to add/social-unified-services-endpoint December 11, 2024 12:45
@manzoorwanijk manzoorwanijk force-pushed the add/social-unified-services-endpoint branch from 1986930 to 0b9b89f Compare December 11, 2024 13:01
@manzoorwanijk manzoorwanijk force-pushed the update/unify-social-connections-schema branch from f937e85 to b6189d1 Compare December 11, 2024 13:01
@manzoorwanijk manzoorwanijk force-pushed the add/social-unified-services-endpoint branch from 0b9b89f to 4eb8da1 Compare December 12, 2024 04:26
@manzoorwanijk manzoorwanijk force-pushed the update/unify-social-connections-schema branch from 533a92c to 19726a5 Compare December 12, 2024 04:27
@manzoorwanijk
Copy link
Member Author

Closing in favour of #40589 which uses a different approach

@manzoorwanijk manzoorwanijk deleted the update/unify-social-connections-schema branch December 12, 2024 12:24
@manzoorwanijk manzoorwanijk restored the update/unify-social-connections-schema branch December 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant