Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update for epidatr 1.0.0 #377

Merged
merged 4 commits into from
Nov 30, 2023
Merged

fix: update for epidatr 1.0.0 #377

merged 4 commits into from
Nov 30, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Nov 16, 2023

  • Fixes vignettes currently failing.
  • Fixes dataset downloading code that relies on epidatr. It might seem like there a lot of changes, but most of those are my IDE automatically applying styler when I saved.
  • Fixes formatting errors in NEWS.md.

Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more straggling covidcast() call. Otherwise LGTM.

vignettes/advanced.Rmd Outdated Show resolved Hide resolved
This was referenced Nov 27, 2023
@dshemetov dshemetov merged commit 8f8f113 into dev Nov 30, 2023
2 checks passed
@dshemetov dshemetov deleted the ds/clean branch November 30, 2023 20:35
nmdefries added a commit to cmu-delphi/epidatasets that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants