Cleanup remains of ServiceMsg #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Simulations
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
alessio
reviewed
Apr 30, 2021
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #9236 +/- ##
==========================================
+ Coverage 60.20% 60.28% +0.08%
==========================================
Files 591 591
Lines 37017 36937 -80
==========================================
- Hits 22285 22269 -16
+ Misses 12758 12698 -60
+ Partials 1974 1970 -4
|
github-actions
bot
added
the
T:Docs
amaury1093
commented
Apr 30, 2021
| // response_fullname is the protobuf fullname of the given sdk.ServiceMsg response | ||
| string response_fullname = 4; | ||
| // msg_type_url contains the TypeURL of a sdk.Msg. | ||
| string msg_type_url = 1; |
There was a problem hiding this comment.
@fdymylja Does this simplification make sense to you?
|
R4R! |
|
Can you fix the conflicts @AmauryM ? |
technicallyty
approved these changes
May 6, 2021
There was a problem hiding this comment.
LGTM - there is still some mention of ServiceMsg in some of the documentation, it's only a few places, maybe it can be changed in this PR?
I found mention of it in:
- x/authz/exported - authorization.go (comment on Accept method)
- x/authz/spec - 01_concepts
- x/authz/spec - 02_state
there's a separate issue for this #9208 |
blushi
approved these changes
May 7, 2021
amaury1093
added
the
A:automerge
10 tasks
This was referenced Dec 30, 2023
cmwaters
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jan 2, 2024
The `ValidateBasic` function has been called in the `GenerateOrBroadcastTxWithFactory` function, so we no longer need to add the `ValidateBasic` function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)
17 tasks
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
The `ValidateBasic` function has been called in the `GenerateOrBroadcastTxWithFactory` function, so we no longer need to add the `ValidateBasic` function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up from #9139, as not to overload that PR, with lower-priority cleanups related to the removal of ServiceMsg TypeURLs.
ref: #9139 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes