PointEvaluationAccumulator

[spapinistarkware]

This change is 

[spapinistarkware]

Current dependencies on/for this PR:

• Support ifft for itnermediate sizes #383
• AVX fft benchmark #382
• ifft_full #381
• Save twiddles #380
• ifft_lower #379
• avx ifft3 #378
• avx vecwise butterflies #377
• avx vecwise ibutterfly #368
• avx ibutterfly #367
• avx butterfly #366
• avx poly #365
• AVX backend #364
• AVX bit reverse #353
• Fri backend #352
• LinePoly backend #350
• Backend #345
• Rename pair_excluder to pair_vanishing #337
• Fibonacci component #332
• CyclicEvaluation #336
• Accumulators #335
• PointEvaluationAccumulator #334 👈
• dev

This stack of pull requests is managed by Graphite.

[shaharsamocha7]

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 3 unresolved discussions (waiting on @spapinistarkware)

---

src/lib.rs line 8 at r1 (raw file):

    slice_group_by,
    stdsimd,
    get_many_mut

Remove

Code quote:

get_many_mut

---

src/core/air/evaluation.rs line 73 at r1 (raw file):

        let rng = &mut StdRng::seed_from_u64(0);
        const MAX_LOG_SIZE: u32 = 10;
        const MASK: u32 = (1 << 30) - 1;

P?

Code quote:

(1 << 30) - 1

---

src/core/air/evaluation.rs line 83 at r1 (raw file):

            .map(|_| M31::from_u32_unchecked(rng.gen::<u32>() & MASK))
            .collect::<Vec<_>>();
        let alpha = m31!(2).into();

Can you take QM31 element here?

Code quote:

m31!(2)

[spapinistarkware]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

src/core/air/evaluation.rs line 83 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you take QM31 element here?

Done.

---

src/lib.rs line 8 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Remove

Done.

[shaharsamocha7]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Merge activity

• Feb 13, 9:21 AM EST: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Feb 13, 9:21 AM EST: @spapinistarkware merged this pull request with Graphite.