Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ifft for itnermediate sizes #383

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Feb 22, 2024

This change is Reviewable

This was referenced Feb 22, 2024
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 8413a4e to 59c04aa Compare February 22, 2024 12:33
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 0841c52 to e29d282 Compare February 22, 2024 12:33
This was referenced Feb 22, 2024
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 59c04aa to 209ea4a Compare February 22, 2024 12:44
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from e29d282 to d0f313b Compare February 22, 2024 12:44
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 209ea4a to 1e1202e Compare February 23, 2024 06:55
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from d0f313b to 8603cd1 Compare February 23, 2024 06:55
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from b2fc1f0 to 234c168 Compare March 3, 2024 11:49
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 2b035c8 to 486ba7b Compare March 3, 2024 11:49
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 234c168 to 0a09f27 Compare March 4, 2024 09:24
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 486ba7b to 73036ec Compare March 4, 2024 09:24
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 0a09f27 to ba639e3 Compare March 4, 2024 10:03
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 73036ec to a89c843 Compare March 4, 2024 10:03
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from ba639e3 to 689e6b3 Compare March 4, 2024 11:03
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from a89c843 to b916539 Compare March 4, 2024 11:04
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 689e6b3 to 36d08a9 Compare March 4, 2024 11:08
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from b916539 to 28c0dbb Compare March 4, 2024 11:08
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 36d08a9 to 4c0af3a Compare March 4, 2024 11:29
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 28c0dbb to 95260d6 Compare March 4, 2024 11:29
@spapinistarkware spapinistarkware changed the title clean up fft Support ifft for itnermediate sizes Mar 4, 2024
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 4c0af3a to 7300d13 Compare March 4, 2024 11:45
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 95260d6 to 31c1986 Compare March 4, 2024 11:45
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/core/backend/avx512/fft.rs line 180 at r1 (raw file):

                ifft1_loop(values, &twiddle_dbl[(layer - 1)..], layer, index_h);
            }
            _ => {}

unreachable?

Code quote:

{}

@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 7300d13 to 8590a89 Compare March 4, 2024 12:24
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from 31c1986 to b5107b7 Compare March 4, 2024 12:35
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 8590a89 to 32dcd65 Compare March 4, 2024 12:35
Copy link

graphite-app bot commented Mar 4, 2024

Merge activity

@spapinistarkware spapinistarkware force-pushed the spapini/02-21-AVX_fft_benchmark branch from 32dcd65 to 22464e9 Compare March 4, 2024 12:38
@spapinistarkware spapinistarkware changed the base branch from spapini/02-21-AVX_fft_benchmark to dev March 4, 2024 12:40
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/stwo/383)
<!-- Reviewable:end -->
@spapinistarkware spapinistarkware force-pushed the spapini/02-21-clean_up_fft branch from b5107b7 to 396c921 Compare March 4, 2024 12:40
@graphite-app graphite-app bot merged commit 396c921 into dev Mar 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants