Rename pair_excluder to pair_vanishing #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2024
Merged
Merged
Merged
alonh5
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
You can remove this PR from the stack and merge it over dev.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
1bc2dcc to
e73ea89
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
9ae4001 to
1fa1414
Compare
alonh5
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
e73ea89 to
fed9d77
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
1fa1414 to
cbf81f3
Compare
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
fed9d77 to
6a26d5d
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
cbf81f3 to
ac17ecf
Compare
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
6a26d5d to
fa22554
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
ac17ecf to
2255208
Compare
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
3 times, most recently
from
84e7309 to
636a47f
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
2255208 to
b6ae3ef
Compare
alonh5
previously approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
636a47f to
3b192a4
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
b6ae3ef to
f9fc462
Compare
spapinistarkware
force-pushed
the
spapini/01-21-Fibonacci_using_component
branch
from
3b192a4 to
c975095
Compare
spapinistarkware
force-pushed
the
spapini/02-13-Rename_pair_excluder_to_pair_vanishing
branch
from
f9fc462 to
2d784f8
Compare
spapinistarkware
changed the base branch from
spapini/01-21-Fibonacci_using_component
to
dev
spapinistarkware
dismissed
alonh5’s stale review
The base branch was changed.
Merged
alonh5
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
This was referenced Feb 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is