ifft_full

[spapinistarkware]

This change is 

[spapinistarkware]

• ColumnOps #459
• Use precomputed twiddles in avx #443
• Precompute twiddles #401
• Remove FRI PolyOps dependency #399
• avx slow eval #398
• avx poly extend #397
• AVX fft eval on larger domains #396
• Reverse order of evaluations #395
• Incorporate fft in AVX backend #394
• AVX regular fft #390
• Separate ifft #389
• Support ifft for itnermediate sizes #383
• AVX fft benchmark #382
• ifft_full #381 👈
• Save twiddles #380
• ifft_lower #379
• avx ifft3 #378
• avx vecwise butterflies #377
• avx vecwise ibutterfly #368
• avx ibutterfly #367
• avx butterfly #366
• avx poly #365
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[ilyalesokhin-starkware]

src/core/backend/avx512/fft.rs line 104 at r2 (raw file):

/// Transposes the AVX vectors in the given array.
/// Swaps the bit index abc <-> cba, where |a|=|c| and |b| = 0 or 1, according to the parity of

is it obvious that this is ok?

Code quote:

Swaps the bit index abc <-> cba, where |a|=|c| and |b| = 0 or 1

[ilyalesokhin-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

---

src/core/backend/avx512/fft.rs line 197 at r2 (raw file):

    for index_h in 0..(1 << (log_size - fft_layers - VECS_LOG_SIZE)) {
        for layer in (0..fft_layers).step_by(3) {
            match fft_layers - layer {

Suggestion:

 while fft_layers - layer >= 3 {
     ...

[ilyalesokhin-starkware]

Reviewed 1 of 2 files at r2.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

[spapinistarkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

src/core/backend/avx512/fft.rs line 197 at r2 (raw file):

    for index_h in 0..(1 << (log_size - fft_layers - VECS_LOG_SIZE)) {
        for layer in (0..fft_layers).step_by(3) {
            match fft_layers - layer {

Look at the last version

[spapinistarkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

src/core/backend/avx512/fft.rs line 104 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

is it obvious that this is ok?

No, but it is ok.

[ilyalesokhin-starkware]

Reviewed 1 of 2 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[graphite-app]

Merge activity

• Mar 4, 6:55 AM EST: spapinistarkware added this pull request to the Graphite merge queue.
• Mar 4, 6:59 AM EST: spapinistarkware merged this pull request with the Graphite merge queue.