Separate ifft

[spapinistarkware]

Separate ifft

Copied ifft into fft

---

This change is 

[spapinistarkware]

• ColumnOps #459
• Use precomputed twiddles in avx #443
• Precompute twiddles #401
• Remove FRI PolyOps dependency #399
• avx slow eval #398
• avx poly extend #397
• AVX fft eval on larger domains #396
• Reverse order of evaluations #395
• Incorporate fft in AVX backend #394
• AVX regular fft #390
• Separate ifft #389 👈
• Support ifft for itnermediate sizes #383
• AVX fft benchmark #382
• ifft_full #381
• Save twiddles #380
• ifft_lower #379
• avx ifft3 #378
• avx vecwise butterflies #377
• avx vecwise ibutterfly #368
• avx ibutterfly #367
• avx butterfly #366
• avx poly #365
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[ilyalesokhin-starkware]

src/core/backend/avx512/fft/mod.rs line 131 at r2 (raw file):

}

// TODO(spapini): Move these to M31 AVX.

still needed?

Code quote:

// TODO(spapini): Move these to M31 AVX.

[ilyalesokhin-starkware]

src/core/backend/avx512/fft/rfft.rs line 10 at r2 (raw file):

    LHALF_INTERLEAVE_LHALF, ODDS_INTERLEAVE_ODDS,
};

what does r in rfft stand for? can you document the file?

[ilyalesokhin-starkware]

Reviewed 2 of 5 files at r2, all commit messages.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @spapinistarkware)

[spapinistarkware]

Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

src/core/backend/avx512/fft/mod.rs line 131 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

still needed?

I'll remove these in a different PR.

---

src/core/backend/avx512/fft/rfft.rs line 10 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

what does r in rfft stand for? can you document the file?

Done.

[ilyalesokhin-starkware]

Reviewed 1 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[graphite-app]

Merge activity

• Mar 6, 9:25 AM EST: spapinistarkware added this pull request to the Graphite merge queue.
• Mar 6, 9:30 AM EST: spapinistarkware merged this pull request with the Graphite merge queue.