-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fri lat layer using coeffs #391
Fri lat layer using coeffs #391
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)
src/core/fri.rs
line 79 at r1 (raw file):
config: FriConfig, inner_layers: Vec<FriLayerProver<H>>, last_layer_coeffs: Vec<SecureField>,
Should we add a comment about the order of the coeffs?
Code quote:
last_layer_coeffs: Vec<SecureField>,
src/core/fri.rs
line 189 at r1 (raw file):
/// The layer is committed to by sending the verifier all the coefficients of the remaining /// polynomial. ///
Add a doc about the return value
Code quote:
///
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
src/core/fri.rs
line 189 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Add a doc about the return value
Done.
008f2bd
to
7fd2853
Compare
5fcff8d
to
3e0f1b0
Compare
3e0f1b0
to
42ef8ff
Compare
42ef8ff
to
c3627c8
Compare
This change is