Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fri lat layer using coeffs #391

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Feb 22, 2024

This change is Reviewable

@spapinistarkware
Copy link
Contributor Author

spapinistarkware commented Feb 22, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Feb 22, 2024
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)


src/core/fri.rs line 79 at r1 (raw file):

    config: FriConfig,
    inner_layers: Vec<FriLayerProver<H>>,
    last_layer_coeffs: Vec<SecureField>,

Should we add a comment about the order of the coeffs?

Code quote:

last_layer_coeffs: Vec<SecureField>,

src/core/fri.rs line 189 at r1 (raw file):

    /// The layer is committed to by sending the verifier all the coefficients of the remaining
    /// polynomial.
    ///

Add a doc about the return value

Code quote:

///

Copy link
Contributor Author

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


src/core/fri.rs line 189 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Add a doc about the return value

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants