Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InteractionElements and LookupValues #802

Merged

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Aug 24, 2024

InteractionElements removed in favour of storing interaction elements the components directly with LookupElements. LookupValues removed in favour of storing lookup values on a claim struct.

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (1ee6a70) to head (8a565ba).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #802   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          89       89           
  Lines       12041    12032    -9     
  Branches    12041    12032    -9     
=======================================
- Hits        11170    11162    -8     
+ Misses        764      763    -1     
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch 3 times, most recently from 62d5e0f to a05370e Compare August 24, 2024 03:43
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from f235b80 to 2a1906b Compare August 24, 2024 03:50
@andrewmilson andrewmilson marked this pull request as ready for review August 24, 2024 04:33
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from a05370e to 5f14eeb Compare August 24, 2024 04:35
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from 2a1906b to 18b014c Compare August 24, 2024 04:36
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 5f14eeb to 4e0f5c8 Compare August 26, 2024 04:15
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from 18b014c to 8b554c7 Compare August 26, 2024 04:15
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 4e0f5c8 to b214af4 Compare August 26, 2024 04:18
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from 8b554c7 to b03472c Compare August 26, 2024 04:18
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)


crates/prover/src/lib.rs line 26 at r1 (raw file):

// removed in favour of storing interaction elements the components directly with LookupElements.
// LookupValues removed in favour of storing lookup values on a claim struct.
// pub mod trace_generation;

Remove. This exists in github history.


crates/prover/src/examples/mod.rs line 4 at r1 (raw file):

pub mod plonk;
pub mod poseidon;
// TODO: Add back once InteractionElements and LookupValues get refactored out. InteractionElements

Same

@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch 2 times, most recently from b6c1cf1 to 12d4559 Compare August 26, 2024 16:26
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7 and @spapinistarkware)


crates/prover/src/lib.rs line 26 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Remove. This exists in github history.

Done.


crates/prover/src/examples/mod.rs line 4 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Same

Done.

@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from b03472c to 2053bd2 Compare August 26, 2024 16:29
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 24 files reviewed, 3 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)

a discussion (no related file):
Samocha is doing this, without deleting fib
https://reviewable.io/reviews/starkware-libs/stwo/812


@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 12d4559 to b02d634 Compare August 28, 2024 02:02
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from 2053bd2 to d6b9dca Compare August 28, 2024 02:02
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from b02d634 to ffd49fd Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from d6b9dca to 6c3daff Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from ffd49fd to 345da9a Compare August 28, 2024 02:18
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from 6c3daff to c126b7a Compare August 28, 2024 02:19
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 345da9a to 9afd058 Compare August 28, 2024 03:07
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from c126b7a to c6bfa66 Compare August 28, 2024 03:07
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 9afd058 to 8053528 Compare August 28, 2024 03:17
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from c6bfa66 to 4e6c433 Compare August 28, 2024 03:18
@andrewmilson andrewmilson force-pushed the 08-21-Pass_entire_mask_to_components branch from 8053528 to bc7f1e0 Compare August 28, 2024 13:03
Base automatically changed from 08-21-Pass_entire_mask_to_components to dev August 28, 2024 13:08
@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch 3 times, most recently from 5ac666f to bd7595e Compare September 3, 2024 06:17
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 15 files at r2, 1 of 3 files at r3, 17 of 17 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)


crates/prover/src/examples/mod.rs line 4 at r4 (raw file):

pub mod plonk;
pub mod poseidon;
pub mod wide_fibonacci;

Remove

Code quote:

pub mod wide_fibonacci;

Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)


crates/prover/src/examples/mod.rs line 4 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Remove

Done.

@andrewmilson andrewmilson force-pushed the 08-23-Remove_InteractionElements_and_LookupValues branch from bd7595e to 8a565ba Compare September 9, 2024 06:13
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

@andrewmilson andrewmilson merged commit 8102837 into dev Sep 9, 2024
15 of 16 checks passed
@andrewmilson andrewmilson deleted the 08-23-Remove_InteractionElements_and_LookupValues branch September 9, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants