-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove InteractionElements and LookupValues #802
Remove InteractionElements and LookupValues #802
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #802 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 89 89
Lines 12041 12032 -9
Branches 12041 12032 -9
=======================================
- Hits 11170 11162 -8
+ Misses 764 763 -1
Partials 107 107 ☔ View full report in Codecov by Sentry. |
62d5e0f
to
a05370e
Compare
f235b80
to
2a1906b
Compare
a05370e
to
5f14eeb
Compare
2a1906b
to
18b014c
Compare
5f14eeb
to
4e0f5c8
Compare
18b014c
to
8b554c7
Compare
4e0f5c8
to
b214af4
Compare
8b554c7
to
b03472c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/lib.rs
line 26 at r1 (raw file):
// removed in favour of storing interaction elements the components directly with LookupElements. // LookupValues removed in favour of storing lookup values on a claim struct. // pub mod trace_generation;
Remove. This exists in github history.
crates/prover/src/examples/mod.rs
line 4 at r1 (raw file):
pub mod plonk; pub mod poseidon; // TODO: Add back once InteractionElements and LookupValues get refactored out. InteractionElements
Same
b6c1cf1
to
12d4559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/lib.rs
line 26 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Remove. This exists in github history.
Done.
crates/prover/src/examples/mod.rs
line 4 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Same
Done.
b03472c
to
2053bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 24 files reviewed, 3 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
a discussion (no related file):
Samocha is doing this, without deleting fib
https://reviewable.io/reviews/starkware-libs/stwo/812
12d4559
to
b02d634
Compare
2053bd2
to
d6b9dca
Compare
b02d634
to
ffd49fd
Compare
d6b9dca
to
6c3daff
Compare
ffd49fd
to
345da9a
Compare
6c3daff
to
c126b7a
Compare
345da9a
to
9afd058
Compare
c126b7a
to
c6bfa66
Compare
9afd058
to
8053528
Compare
c6bfa66
to
4e6c433
Compare
8053528
to
bc7f1e0
Compare
5ac666f
to
bd7595e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 15 files at r2, 1 of 3 files at r3, 17 of 17 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/examples/mod.rs
line 4 at r4 (raw file):
pub mod plonk; pub mod poseidon; pub mod wide_fibonacci;
Remove
Code quote:
pub mod wide_fibonacci;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)
crates/prover/src/examples/mod.rs
line 4 at r4 (raw file):
Previously, shaharsamocha7 wrote…
Remove
Done.
bd7595e
to
8a565ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
InteractionElements removed in favour of storing interaction elements the components directly with LookupElements. LookupValues removed in favour of storing lookup values on a claim struct.
This change is