-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create blake example that uses GKR for lookups #807
base: dev
Are you sure you want to change the base?
Create blake example that uses GKR for lookups #807
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 08-24-Create_MLE_eval_verifier_component #807 +/- ##
============================================================================
- Coverage 92.95% 92.60% -0.35%
============================================================================
Files 89 89
Lines 12037 12097 +60
Branches 12037 12097 +60
============================================================================
+ Hits 11189 11203 +14
- Misses 741 787 +46
Partials 107 107 ☔ View full report in Codecov by Sentry. |
eec9cb8
to
2f7ebf2
Compare
90b629e
to
714346f
Compare
2f7ebf2
to
ddd533f
Compare
714346f
to
d1436e5
Compare
ddd533f
to
364bdc2
Compare
d1436e5
to
fb1df16
Compare
364bdc2
to
4db6d30
Compare
fb1df16
to
c096475
Compare
4db6d30
to
1bca1a7
Compare
c096475
to
f484d61
Compare
1bca1a7
to
6d88a87
Compare
f484d61
to
07025b9
Compare
6d88a87
to
f06afde
Compare
07025b9
to
18796fa
Compare
f06afde
to
4c9bc7e
Compare
18796fa
to
bf7a97a
Compare
4c9bc7e
to
4f24c54
Compare
bf7a97a
to
a956cef
Compare
4f24c54
to
fff9df9
Compare
a956cef
to
5e93d84
Compare
fff9df9
to
35ba7cb
Compare
5e93d84
to
ad79e22
Compare
5373213
to
4e92911
Compare
ad79e22
to
b7cadcf
Compare
4e92911
to
14eb2a2
Compare
b7cadcf
to
4ab463b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 28 files at r1, all commit messages.
Reviewable status: 4 of 28 files reviewed, 3 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/constraint_framework/component.rs
line 70 at r1 (raw file):
fn evaluate<E: EvalAtRowWithMle>(&self, eval: E) -> E; }
Can we move this to the GKR folder?
Code quote:
/// A component defined solely in means of the constraints framework.
/// Implementing this trait introduces implementations for [`Component`] and [`ComponentProver`] for
/// the SIMD backend.
/// Note that the constraint framework only support components with columns of the same size.
pub trait FrameworkEvalWithMle {
fn log_size(&self) -> u32;
fn max_constraint_log_degree_bound(&self) -> u32;
fn evaluate<E: EvalAtRowWithMle>(&self, eval: E) -> E;
}
crates/prover/src/constraint_framework/mod.rs
line 101 at r1 (raw file):
trait EvalAtRowWithMle: EvalAtRow { fn add_mle_coeff_col_eval(&mut self, eval: Self::EF); }
same
Code quote:
trait EvalAtRowWithMle: EvalAtRow {
fn add_mle_coeff_col_eval(&mut self, eval: Self::EF);
}
crates/prover/src/constraint_framework/point.rs
line 58 at r1 (raw file):
} }
Remove
14eb2a2
to
f1d17af
Compare
4ab463b
to
55402a0
Compare
f1d17af
to
a969689
Compare
55402a0
to
3df0cb9
Compare
a969689
to
cc6929c
Compare
3df0cb9
to
e56d31e
Compare
This change is