-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MLE eval verifier component #805
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #805 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 90 90
Lines 12400 12400
Branches 12400 12400
=======================================
Hits 11467 11467
Misses 825 825
Partials 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a7d37ba
to
eec9cb8
Compare
c1ac882
to
3fde6e5
Compare
eec9cb8
to
2f7ebf2
Compare
3fde6e5
to
bb56a26
Compare
2f7ebf2
to
ddd533f
Compare
bb56a26
to
110a7b8
Compare
ddd533f
to
364bdc2
Compare
110a7b8
to
6b4cd33
Compare
364bdc2
to
4db6d30
Compare
6b4cd33
to
7af83e4
Compare
4db6d30
to
1bca1a7
Compare
7af83e4
to
3e7fdfa
Compare
1bca1a7
to
6d88a87
Compare
3e7fdfa
to
4e0bed5
Compare
6d88a87
to
f06afde
Compare
4e0bed5
to
4953abd
Compare
f06afde
to
4c9bc7e
Compare
4953abd
to
283d17a
Compare
4c9bc7e
to
4f24c54
Compare
283d17a
to
62443c5
Compare
4f24c54
to
fff9df9
Compare
62443c5
to
cb773df
Compare
fff9df9
to
35ba7cb
Compare
cb773df
to
d8ff784
Compare
35ba7cb
to
5373213
Compare
d8ff784
to
2dcf095
Compare
5373213
to
4e92911
Compare
2dcf095
to
f0d2917
Compare
4e92911
to
14eb2a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @spapinistarkware)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 356 at r2 (raw file):
let mle_coeff_col_eval = self.mle_coeff_column_oracle.evaluate_at_point(point, mask); let carry_quotients_col_eval = eval_carry_quotient_col(&self.mle_eval_point, point); let is_first = eval_is_first(trace_coset, point);
Should we use this succinct version instead of committing to the is_first column in the constant tree?
Code quote:
eval_is_first(trace_coset, point)
f0d2917
to
8f1ab06
Compare
14eb2a2
to
f1d17af
Compare
8f1ab06
to
5b3001a
Compare
f1d17af
to
a969689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 356 at r2 (raw file):
Previously, shaharsamocha7 wrote…
Should we use this succinct version instead of committing to the is_first column in the constant tree?
We could. I remember ShaharP mentioning he thought constant column might be more efficient for the verifier. Not sure if this is just Bitcoin case or all cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @spapinistarkware)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 356 at r2 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
We could. I remember ShaharP mentioning he thought constant column might be more efficient for the verifier. Not sure if this is just Bitcoin case or all cases
coset_vanishing(coset, p) / (point_vanishing(coset.initial, p) * BaseField::from(1 << coset.log_size))
Maybe it is because of the inverse but I guess that we can implement it efficiently using a hint.
a969689
to
cc6929c
Compare
This change is