-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build trace functions for MLE eval component #803
Add build trace functions for MLE eval component #803
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #803 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 89 89
Lines 12032 12032
Branches 12032 12032
=======================================
Hits 11162 11162
Misses 763 763
Partials 107 107 ☔ View full report in Codecov by Sentry. |
18b014c
to
8b554c7
Compare
af52728
to
1093cee
Compare
8b554c7
to
b03472c
Compare
1093cee
to
fd8ce1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 156 at r1 (raw file):
#[cfg(test)] assert_eq!(claim, mle.eval_at_point(eval_point));
Consider
Suggestion:
debug_assert_eq!(claim, mle.eval_at_point(eval_point));
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 159 at r1 (raw file):
let shift = claim / BaseField::from(mle.len()); let packed_shift_coords = PackedSecureField::broadcast(shift).into_packed_m31s(); let mut shifted_mle_terms_cols = mle_terms_cols.clone();
Suggestion:
let mut shifted_mle_terms_cols = mle_terms_cols;
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 188 at r1 (raw file):
) -> Vec<CircleEvaluation<SimdBackend, BaseField, BitReversedOrder>> { let log_size = N_VARIABLES as u32; vec![gen_is_first(log_size)]
Techinically, you can also compute this using vanishing cosets, same way you did for the smaller ones.
b03472c
to
2053bd2
Compare
fd8ce1f
to
71f60f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 156 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Consider
need the cfg(test) since eval_at_point defined behind cfg(test)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 159 at r1 (raw file):
let shift = claim / BaseField::from(mle.len()); let packed_shift_coords = PackedSecureField::broadcast(shift).into_packed_m31s(); let mut shifted_mle_terms_cols = mle_terms_cols.clone();
ty
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 188 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Techinically, you can also compute this using vanishing cosets, same way you did for the smaller ones.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
2053bd2
to
d6b9dca
Compare
71f60f3
to
765f537
Compare
d6b9dca
to
6c3daff
Compare
765f537
to
9eb0dfa
Compare
6c3daff
to
c126b7a
Compare
9eb0dfa
to
4f77d82
Compare
c126b7a
to
c6bfa66
Compare
4f77d82
to
e67c1c5
Compare
c6bfa66
to
4e6c433
Compare
e67c1c5
to
ce9c26a
Compare
4e6c433
to
bdbb4a3
Compare
ce9c26a
to
028665a
Compare
bdbb4a3
to
5ac666f
Compare
028665a
to
7fd99fa
Compare
5ac666f
to
bd7595e
Compare
7fd99fa
to
b58bab4
Compare
bd7595e
to
8a565ba
Compare
b58bab4
to
1e9e342
Compare
This change is