Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arithmetic op counts to InfoEvaluator #832

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 16, 2024

Couldn't see a way to add the counting types without removing Copy from a few places.
Some constraint code is a bit more ugly now :(


This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Sep 16, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 90.94828% with 21 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (56a6a61) to head (840ed3e).

Files with missing lines Patch % Lines
crates/prover/src/constraint_framework/info.rs 94.78% 9 Missing and 2 partials ⚠️
crates/prover/src/core/backend/simd/qm31.rs 0.00% 6 Missing ⚠️
crates/prover/src/constraint_framework/expr.rs 0.00% 3 Missing ⚠️
crates/prover/src/core/lookups/utils.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #832      +/-   ##
==========================================
- Coverage   91.94%   91.93%   -0.02%     
==========================================
  Files          93       93              
  Lines       13092    13312     +220     
  Branches    13092    13312     +220     
==========================================
+ Hits        12038    12238     +200     
- Misses        939      957      +18     
- Partials      115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch 2 times, most recently from 4c79a3d to d79f369 Compare September 16, 2024 05:23
Base automatically changed from 09-11-Add_size_estimate_for_StarkProof to dev September 16, 2024 19:18
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from d79f369 to 798f58a Compare September 24, 2024 05:20
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from 798f58a to a46c994 Compare September 25, 2024 21:22
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 15 files at r1, 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)


crates/prover/src/examples/poseidon/mod.rs line 30 at r3 (raw file):

use crate::core::ColumnVec;

const N_LOG_INSTANCES_PER_ROW: usize = 0;

It still works with 3 though, right?

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from a46c994 to 19e4fac Compare November 19, 2024 13:58
This was referenced Nov 19, 2024
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch 2 times, most recently from deca512 to b32c8bc Compare November 24, 2024 03:58
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 19 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)


crates/prover/src/examples/poseidon/mod.rs line 30 at r3 (raw file):

Previously, Alon-Ti wrote…

It still works with 3 though, right?

It does. Reverted back

@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from b32c8bc to e5fe5d9 Compare November 24, 2024 04:04
@andrewmilson andrewmilson force-pushed the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch from e5fe5d9 to 840ed3e Compare November 24, 2024 04:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e5fe5d9 Previous: f6214d1 Ratio
merkle throughput/simd merkle 29850012 ns/iter (± 871197) 14690867 ns/iter (± 434150) 2.03

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 16 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@andrewmilson andrewmilson merged commit cd8b37b into dev Nov 24, 2024
19 checks passed
@andrewmilson andrewmilson deleted the 09-15-Add_arithmetic_op_counts_to_InfoEvaluator branch November 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants