Make CommitmentSchemeProver::prove_values take ownership

[andrewmilson]

Simplifies the implementation of quotient commitment tree in following PR

This change is 

[andrewmilson]

• Make CommitmentSchemeProver::prove_values take ownership #852 : 2 dependent PRs (#856 , #897 ) 👈 (View in Graphite)
• Add arithmetic op counts to InfoEvaluator #832
• Add size estimate for StarkProof #831
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (cd8b37b) to head (bbe8f96).

Files with missing lines	Patch %	Lines
crates/prover/src/core/prover/mod.rs	50.00%	11 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #852      +/-   ##
==========================================
+ Coverage   91.93%   91.95%   +0.02%     
==========================================
  Files          93       93              
  Lines       13312    13308       -4     
  Branches    13312    13308       -4     
==========================================
- Hits        12238    12237       -1     
+ Misses        957      954       -3     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[Alon-Ti]

up to stylistic question.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)

---

crates/prover/src/core/prover/mod.rs line 150 at r1 (raw file):

    fn extract_composition_oods_eval(&self) -> Result<SecureField, InvalidOodsSampleStructure> {
        // TODO(andrew): `[.., composition_mask, _quotients_mask]` when add quotients commitment.
        let [_traces_mask @ .., composition_mask] = &**self.sampled_values else {

Why are you binding traces_mask?

[andrewmilson]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)

---

crates/prover/src/core/prover/mod.rs line 150 at r1 (raw file):

Previously, Alon-Ti wrote…

Why are you binding traces_mask?

I would have done _ @ .. but it errors strangely.

OHHH. Wow didn't realise you can just do .. SMH, tyty

[Alon-Ti]

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

[shaharsamocha7]

Reviewed 3 of 9 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: bbe8f96	Previous: cd8b37b	Ratio
merkle throughput/simd merkle	27701539 ns/iter (± 437610)	13712527 ns/iter (± 579195)	2.02

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

[shaharsamocha7]

Reviewed 9 of 9 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

---

crates/prover/src/examples/plonk/mod.rs line 301 at r3 (raw file):

        let sizes = component.trace_log_degree_bounds();

        // Constant columns.

rename

Suggestion:

// Preprocessed columns.

[andrewmilson]

Reviewable status: 8 of 11 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

---

crates/prover/src/examples/plonk/mod.rs line 301 at r3 (raw file):

Previously, shaharsamocha7 wrote…

rename

Done thanks