Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9225: Create ApiClients class and provide it to BOS operators inside a context manager #399

Open
wants to merge 1 commit into
base: casmcms-9225-03-api-clients
Choose a base branch
from

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Dec 17, 2024

CASMCMS-9225 as a whole involves changes to a number of different files in BOS. In order to aid with review, I'm breaking the overall thing up into smaller PRs. Each will be built on top of each other, and will be merging into the main PR branch. Only once each sub-PR has been approved and merged will I merge that branch into develop.
Full list of sub-PRs:

  1. Added basic paging ability for GET requests to list components
  2. Create generic endpoint classes
  3. Create generic API client class
  4. Create ApiClients class and provide it to BOS operators inside a context manager
  5. Move PCS client to new paradigm
  6. Move BSS client to new paradigm
  7. Move CFS client to new paradigm
  8. Move BOS client to new paradigm
  9. Move IMS client to new paradigm
  10. Move HSM client to new paradigm
  11. CHANGELOG update, linting, update utils

This PR is the first step to providing the new API client interfaces to the BOS operators. This creates the ApiClients class, which is a context manager that is just a collection of API clients. In this PR, no actual API clients are included -- I have left them commented. The upcoming PRs will add them. This PR just shows how this new ApiClients class is initialized in a context manager that goes around the operator _run() method. All of the work of the operator is done in there, and so we can safely use that for our context, knowing that the API clients will be available to the operators as they do their work.

@mharding-hpe mharding-hpe force-pushed the casmcms-9225-03-api-clients branch from 66b20d2 to 3b8b36c Compare December 17, 2024 18:43
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-04-operator-api-client branch 2 times, most recently from 3feee62 to c5e73d6 Compare December 17, 2024 19:14
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-03-api-clients branch from 664a1a7 to 6268c27 Compare December 17, 2024 21:18
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-04-operator-api-client branch from c5e73d6 to cca42de Compare December 17, 2024 21:18
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-03-api-clients branch from 6268c27 to 36528e1 Compare December 17, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants