Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9225: Move HSM client to new paradigm #405

Open
wants to merge 1 commit into
base: casmcms-9225-09-ims-client
Choose a base branch
from

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Dec 17, 2024

CASMCMS-9225 as a whole involves changes to a number of different files in BOS. In order to aid with review, I'm breaking the overall thing up into smaller PRs. Each will be built on top of each other, and will be merging into the main PR branch. Only once each sub-PR has been approved and merged will I merge that branch into develop.
Full list of sub-PRs:

  1. Added basic paging ability for GET requests to list components
  2. Create generic endpoint classes
  3. Create generic API client class
  4. Create ApiClients class and provide it to BOS operators inside a context manager
  5. Move PCS client to new paradigm
  6. Move BSS client to new paradigm
  7. Move CFS client to new paradigm
  8. Move BOS client to new paradigm
  9. Move IMS client to new paradigm
  10. Move HSM client to new paradigm
  11. CHANGELOG update, linting, update utils

This PR is the same as the one for PCS, but for HSM instead. The only noteworthy difference is that like with CFS and BOS, one filter had to be updated to use the HSM client.

@mharding-hpe mharding-hpe requested a review from a team as a code owner December 17, 2024 20:52
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-09-ims-client branch from a6bd7ea to 32a97ec Compare December 17, 2024 21:20
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-10-hsm-client branch from bad10d9 to 4e70ca4 Compare December 17, 2024 21:20
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-09-ims-client branch from 32a97ec to 1122eba Compare December 17, 2024 23:30
from .exceptions import HWStateManagerException

SERVICE_NAME = 'cray-smd'
ENDPOINT = f"{PROTOCOL}://{SERVICE_NAME}/hsm/v2/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contansts for api version and "hsm"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants