Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9225: Move BSS client to new paradigm #401

Open
wants to merge 1 commit into
base: casmcms-9225-05-pcs-client
Choose a base branch
from

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Dec 17, 2024

CASMCMS-9225 as a whole involves changes to a number of different files in BOS. In order to aid with review, I'm breaking the overall thing up into smaller PRs. Each will be built on top of each other, and will be merging into the main PR branch. Only once each sub-PR has been approved and merged will I merge that branch into develop.
Full list of sub-PRs:

  1. Added basic paging ability for GET requests to list components
  2. Create generic endpoint classes
  3. Create generic API client class
  4. Create ApiClients class and provide it to BOS operators inside a context manager
  5. Move PCS client to new paradigm
  6. Move BSS client to new paradigm
  7. Move CFS client to new paradigm
  8. Move BOS client to new paradigm
  9. Move IMS client to new paradigm
  10. Move HSM client to new paradigm
  11. CHANGELOG update, linting, update utils

This PR is the same as the one for PCS, but for BSS instead. The only noteworthy difference is that with BSS, the part of the response that we care about is in the header. This is why BaseBssEndpoint is a subclass of BaseRawEndpoint instead of BaseEndpoint. And you can see inside the set_bss method in the BootParametersEndpoint class, it accesses the header field of the ResponseData object that it receives from its put request.

@mharding-hpe mharding-hpe requested a review from a team as a code owner December 17, 2024 18:29
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-05-pcs-client branch from 5351949 to aeb4dd8 Compare December 17, 2024 18:43
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-06-bss-client branch from ac96eef to 448bfdd Compare December 17, 2024 18:44
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-05-pcs-client branch from aeb4dd8 to 5d71e51 Compare December 17, 2024 19:14
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-06-bss-client branch 3 times, most recently from 5cfcb10 to 116c7ab Compare December 17, 2024 19:37
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-05-pcs-client branch from e27ac01 to 4b47029 Compare December 17, 2024 21:18
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-06-bss-client branch from 116c7ab to 92b42a8 Compare December 17, 2024 21:19
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-05-pcs-client branch from 4b47029 to b9df182 Compare December 17, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants