-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMCMS-9225: Move BOS client to new paradigm #403
Open
mharding-hpe
wants to merge
2
commits into
casmcms-9225-07-cfs-client
Choose a base branch
from
casmcms-9225-08-bos-client
base: casmcms-9225-07-cfs-client
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CASMCMS-9225: Move BOS client to new paradigm #403
mharding-hpe
wants to merge
2
commits into
casmcms-9225-07-cfs-client
from
casmcms-9225-08-bos-client
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
force-pushed
the
casmcms-9225-08-bos-client
branch
from
December 17, 2024 20:16
8d962bf
to
9bc2d85
Compare
mharding-hpe
requested review from
jsl-hpe,
jsollom-hpe,
rbak-hpe and
kumarrahul04
December 17, 2024 20:21
mharding-hpe
force-pushed
the
casmcms-9225-07-cfs-client
branch
from
December 17, 2024 21:19
88b9ac7
to
d07355a
Compare
mharding-hpe
force-pushed
the
casmcms-9225-08-bos-client
branch
from
December 17, 2024 21:19
9bc2d85
to
6a31f7a
Compare
mharding-hpe
force-pushed
the
casmcms-9225-07-cfs-client
branch
from
December 17, 2024 23:29
d07355a
to
18c373b
Compare
mharding-hpe
force-pushed
the
casmcms-9225-08-bos-client
branch
from
December 17, 2024 23:29
6a31f7a
to
bccce47
Compare
kumarrahul04
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewd, posted clarification questions.
This was referenced Dec 18, 2024
Open
Address code review suggestion
kumarrahul04
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as the one for PCS, but for BOS instead. The only noteworthy differences are:
options
module was left unchanged for the time being, apart from being moved over to use a context manager, and moving to the new location inside the repo.