Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9225: Move BOS client to new paradigm #403

Open
wants to merge 2 commits into
base: casmcms-9225-07-cfs-client
Choose a base branch
from

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Dec 17, 2024

CASMCMS-9225 as a whole involves changes to a number of different files in BOS. In order to aid with review, I'm breaking the overall thing up into smaller PRs. Each will be built on top of each other, and will be merging into the main PR branch. Only once each sub-PR has been approved and merged will I merge that branch into develop.
Full list of sub-PRs:

  1. Added basic paging ability for GET requests to list components
  2. Create generic endpoint classes
  3. Create generic API client class
  4. Create ApiClients class and provide it to BOS operators inside a context manager
  5. Move PCS client to new paradigm
  6. Move BSS client to new paradigm
  7. Move CFS client to new paradigm
  8. Move BOS client to new paradigm
  9. Move IMS client to new paradigm
  10. Move HSM client to new paradigm
  11. CHANGELOG update, linting, update utils

This PR is the same as the one for PCS, but for BOS instead. The only noteworthy differences are:

  1. The BOS options module was left unchanged for the time being, apart from being moved over to use a context manager, and moving to the new location inside the repo.
  2. Like with CFS, one filter needed to be updated and added to the base operator, to enable it to use the built-in BOS client.

@mharding-hpe mharding-hpe requested a review from a team as a code owner December 17, 2024 20:13
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-08-bos-client branch from 8d962bf to 9bc2d85 Compare December 17, 2024 20:16
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-07-cfs-client branch from 88b9ac7 to d07355a Compare December 17, 2024 21:19
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-08-bos-client branch from 9bc2d85 to 6a31f7a Compare December 17, 2024 21:19
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-07-cfs-client branch from d07355a to 18c373b Compare December 17, 2024 23:29
@mharding-hpe mharding-hpe force-pushed the casmcms-9225-08-bos-client branch from 6a31f7a to bccce47 Compare December 17, 2024 23:29
Copy link

@kumarrahul04 kumarrahul04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewd, posted clarification questions.

Address code review suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants