-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMCMS-9225: Added basic paging ability for GET requests to list components #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
requested review from
jsl-hpe,
jsollom-hpe,
rbak-hpe and
kumarrahul04
December 17, 2024 14:38
mharding-hpe
force-pushed
the
casmcms-9225-01-paging
branch
2 times, most recently
from
December 17, 2024 14:47
586cfa3
to
24bdb6b
Compare
mharding-hpe
force-pushed
the
casmcms-9225-01-paging
branch
from
December 17, 2024 15:08
24bdb6b
to
2b181ad
Compare
kumarrahul04
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comments added.
mharding-hpe
commented
Dec 17, 2024
… return empty list if id_list&tenant_components is empty
mharding-hpe
force-pushed
the
casmcms-9225-01-paging
branch
from
December 17, 2024 17:05
7d5a911
to
347ccc0
Compare
kumarrahul04
approved these changes
Dec 17, 2024
jsollom-hpe
approved these changes
Dec 17, 2024
Co-authored-by: Jason Sollom <[email protected]>
This was referenced Dec 18, 2024
Open
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASMCMS-9225 overall is addressing problems I found when investigating possible resource leaks in BOS (related to Josh Williamson's memory leak investigation with PCS). In the past we've made other changes to BOS to ensure that its requests to services like PCS and CFS do not get excessively large (this was done mostly by adding the
max_component_batch_size
option). However, one thing that was not addressed by this was when the BOS operators poll BOS itself to figure out which components require action. In those cases, the size of the request responses can end up scaling linearly with the number of nodes in the system, and on mug I observed that this could lead to two problems:This PR makes the following changes:
max_page_size
andstart_after_id
). These enable paging when listing BOS components. They are both optional, and if they are not specified, BOS works exactly as before. Thus, they are entirely backward-compatible. My current plan is not to add these to the Cray CLI -- their main purpose is for BOS internal use, although of course anyone using the API is free to use them. If there is demand, it would not be difficult to add them into the CLI, however.This PR does NOT yet modify the BOS operators to use these new abilities. That will be in a separate PR, because that code ended up being refactored for other reasons.