Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_ap components #215

Merged
merged 1 commit into from
Dec 3, 2024
Merged

add_ap components #215

merged 1 commit into from
Dec 3, 2024

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 1, 2024

This change is Reviewable

@ohad-starkware ohad-starkware self-assigned this Dec 1, 2024
@ohad-starkware ohad-starkware mentioned this pull request Dec 1, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/add_ap_prove branch 2 times, most recently from 4e5d58f to 3aeb156 Compare December 1, 2024 15:29
@ohad-starkware ohad-starkware mentioned this pull request Dec 1, 2024
@ohad-starkware ohad-starkware changed the base branch from ohad/update_gen to ohad/snake_case_generic_verifyh December 2, 2024 06:17
@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
Merged
@ohad-starkware ohad-starkware changed the base branch from ohad/snake_case_generic_verifyh to ohad/update_gen December 2, 2024 06:19
@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/update_gen branch 2 times, most recently from 0cebfc6 to 2565630 Compare December 2, 2024 07:47
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 12 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

Copy link
Contributor Author

ohad-starkware commented Dec 3, 2024

Merge activity

  • Dec 3, 6:55 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 3, 6:57 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 3, 7:00 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/update_gen to graphite-base/215 December 3, 2024 11:55
@ohad-starkware ohad-starkware changed the base branch from graphite-base/215 to main December 3, 2024 11:55
@ohad-starkware ohad-starkware merged commit 11c3f04 into main Dec 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants