jump

[ohad-starkware]

This change is 

[ohad-starkware]

• tracking relations #229 : 2 dependent PRs (#231 , #233 )
• call #222
• is first and row bounds relaxations #228
• jump #221 👈 (View in Graphite)
• add opcode #220
• mul #219
• assert gen #218
• jnz gen #217
• migrated opcodes air out of cairo air #216
• add_ap components #215
• update verify generic and ret from auto gen #214
• snake case generic and verify #209
• renamed relations #208
• pub use for memory and range checks #207
• renamed memory components #206
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 15 files reviewed, 3 unresolved discussions (waiting on @ohad-starkware)

---

a discussion (no related file):
Rename the jumps to
jump_x_y_z (x,y,z \in {f,t})

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 48 at r4 (raw file):

    jnz_t_t: Vec<jnz_opcode_is_taken_t_dst_base_fp_t::Claim>,
    jump_f_f: Vec<jump_opcode_is_rel_f_is_imm_f_is_double_deref_f::Claim>,
    jump_f_t: Vec<jump_opcode_is_rel_f_is_imm_f_is_double_deref_t::Claim>,

Rename to jump_fft :)

Suggestion:

jump_f_f_t: Vec<jump_opcode_is_rel_f_is_imm_f_is_double_deref_t::Claim>

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 74 at r4 (raw file):

        self.jump_f_f.iter().for_each(|c| c.mix_into(channel));
        self.jump_f_t.iter().for_each(|c| c.mix_into(channel));
        self.jump_t_f.iter().for_each(|c| c.mix_into(channel));

You missed one

Suggestion:

        self.jump_f_f.iter().for_each(|c| c.mix_into(channel));
        self.jump_f_t.iter().for_each(|c| c.mix_into(channel));
        self.jump_t_f.iter().for_each(|c| c.mix_into(channel));
        self.jump_t_t.iter().for_each(|c| c.mix_into(channel));

[ohad-starkware]

Reviewable status: 0 of 15 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

a discussion (no related file):

Previously, shaharsamocha7 wrote…

Rename the jumps to
jump_x_y_z (x,y,z \in {f,t})

Done.s

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 48 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Rename to jump_fft :)

Done.

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 74 at r4 (raw file):

Previously, shaharsamocha7 wrote…

You missed one

Done.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 15 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 154 at r5 (raw file):

        let mut jump_f_t = vec![];
        let mut jump_t_f = vec![];
        let mut jump_t_t = vec![];

also here
and anywhere

Code quote:

        let mut jump_f_f = vec![];
        let mut jump_f_t = vec![];
        let mut jump_t_f = vec![];
        let mut jump_t_t = vec![];

[ohad-starkware]

Reviewable status: 0 of 15 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 154 at r5 (raw file):

Previously, shaharsamocha7 wrote…

also here
and anywhere

Done.

[shaharsamocha7]

Reviewed 12 of 15 files at r1, 1 of 3 files at r4, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 1184 at r6 (raw file):

            })
            .collect();
        let jump_f_f_interaction_claims = self

:(

Suggestion:

let jump_f_f_f_interaction_claims = self

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 1693 at r6 (raw file):

            })
            .collect_vec();
        let jump_f_f_components = claim

:( x2

Suggestion:

 let jump_f_f_f_components = claim

[ohad-starkware]

Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 1184 at r6 (raw file):

Previously, shaharsamocha7 wrote…

:(

Done.

---

stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 1693 at r6 (raw file):

Previously, shaharsamocha7 wrote…

:( x2

:O

[shaharsamocha7]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[ohad-starkware]

Merge activity

• Dec 5, 10:57 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 5, 11:05 AM EST: Graphite rebased this pull request as part of a merge.
• Dec 5, 11:09 AM EST: A user merged this pull request with Graphite.