-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrated opcodes air out of cairo air #216
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
801e35c
to
82b34f3
Compare
4e5d58f
to
3aeb156
Compare
e0b935d
to
2e85633
Compare
3aeb156
to
6eb3827
Compare
2e85633
to
80578d3
Compare
6eb3827
to
920a04b
Compare
80578d3
to
cc8dc6f
Compare
920a04b
to
a079739
Compare
cc8dc6f
to
3ffed25
Compare
a079739
to
b4d1596
Compare
3ffed25
to
4936aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs
line 51 at r2 (raw file):
let mut mem_file = std::io::BufReader::new(std::fs::File::open(mem_path)?); let mut mem = MemoryBuilder::from_iter(mem_config, MemEntryIter(&mut mem_file)); let state_transitions = StateTransitions::from_iter(TraceIter(&mut trace_file), &mut mem, true);
how did it work if it was set to false?
Code quote:
, true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs
line 51 at r2 (raw file):
Previously, shaharsamocha7 wrote…
how did it work if it was set to false?
the test that takes casm doesnt pass here
and the other tests are ignored
b4d1596
to
db2f980
Compare
4936aeb
to
6de6990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
6de6990
to
5b6cd35
Compare
db2f980
to
32a80d4
Compare
5b6cd35
to
fa0067e
Compare
This change is