Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated opcodes air out of cairo air #216

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 1, 2024

This change is Reviewable

@ohad-starkware ohad-starkware self-assigned this Dec 1, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/opcode_migration branch 2 times, most recently from 801e35c to 82b34f3 Compare December 1, 2024 13:36
@ohad-starkware ohad-starkware mentioned this pull request Dec 1, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/add_ap_prove branch 2 times, most recently from 4e5d58f to 3aeb156 Compare December 1, 2024 15:29
@ohad-starkware ohad-starkware force-pushed the ohad/opcode_migration branch 2 times, most recently from e0b935d to 2e85633 Compare December 1, 2024 15:32
This was referenced Dec 1, 2024
Merged
@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs line 51 at r2 (raw file):

    let mut mem_file = std::io::BufReader::new(std::fs::File::open(mem_path)?);
    let mut mem = MemoryBuilder::from_iter(mem_config, MemEntryIter(&mut mem_file));
    let state_transitions = StateTransitions::from_iter(TraceIter(&mut trace_file), &mut mem, true);

how did it work if it was set to false?

Code quote:

, true

@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/input/vm_import/mod.rs line 51 at r2 (raw file):

Previously, shaharsamocha7 wrote…

how did it work if it was set to false?

the test that takes casm doesnt pass here
and the other tests are ignored

Copy link
Contributor Author

ohad-starkware commented Dec 3, 2024

Merge activity

  • Dec 3, 6:55 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 3, 7:03 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 3, 7:06 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/add_ap_prove to graphite-base/216 December 3, 2024 11:56
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware changed the base branch from graphite-base/216 to main December 3, 2024 12:00
@ohad-starkware ohad-starkware merged commit 0f76033 into main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants