-
Notifications
You must be signed in to change notification settings - Fork 1
Pull requests and how they are reviewed and approved
Zacharias Tyllström edited this page Sep 15, 2019
·
1 revision
The master branch is currently protected from any remote pushes. So the only way to update the master branch is via a merge with a different branch. The process would be as follows:
- First you need to checkout a new branch that is dedicated to a specific issue.
- When the issue is completed and you want to merge your branch with master you need approval from 2 different group members. This way we can avoid any annoying merge issues and it is less likely that there will be introduced bugs to the master when you have 2 people reviewing your code.
- When the branch have been merged and the issue has been closed we delete that branch. We do this to avoid cluttering our repos with branches that are not actively developed or updated.
All pull requests can be found here.